XEOK-54 Expose SceneModelEntity's area and volume#1577
Draft
MichalDybizbanskiCreoox wants to merge 2 commits intomasterfrom
Draft
XEOK-54 Expose SceneModelEntity's area and volume#1577MichalDybizbanskiCreoox wants to merge 2 commits intomasterfrom
MichalDybizbanskiCreoox wants to merge 2 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>xeokit Example</title> | ||
| <link href="../css/pageStyle.css" rel="stylesheet"/> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/js/all.min.js"></script> |
Check warning
Code scanning / CodeQL
Inclusion of functionality from an untrusted source
Contributor
|
Shouldn't volume calculations be only available for entities made exclusively of watertight meshes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
SceneModelEntity::areaand::volumegetters.The metrics are computed during load time, and don't rely on run-time geometry information, thus assuming
SceneModelEntitygeometries don't change.IMPORTANT: The metrics have been implemented for
VBOBatchingTrianglesLayerandVBOInstancingTrianglesLayer, but not forDTXTrianglesLayer.Another PR has been merged to the master branch, which uses a different approach, but provides the same metrics, at
#1574
so this one becomes a Draft PR for the time being.