[FEATURE] Supporting vertex colors for gltf loading#1845
Draft
paireks wants to merge 3 commits intoxeokit:masterfrom
Draft
[FEATURE] Supporting vertex colors for gltf loading#1845paireks wants to merge 3 commits intoxeokit:masterfrom
paireks wants to merge 3 commits intoxeokit:masterfrom
Conversation
b822c16 to
b55474a
Compare
MichalDybizbanskiCreoox
approved these changes
Mar 31, 2025
Member
Author
|
Ok, after reading a bit more of documentation and experiments I think I get it a bit more, hope to discuss it tomorrow with you |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @xeolabs and @MichalDybizbanskiCreoox!
I wanted to add vertex color support to our gltf loader. This PR is adding it, so we can load it like this:

The thing I cannot figure out is loading existing HousePlan file. After a change it looks like this:

When I debugged it, it looks like this model contains the vertex colors, that are all (1,1,1,1) -> (which is all white), that's why it changed this color to white. Some other models don't have that, they just don't have vertex colors. I don't think ignoring vertex colors when they are all 1,1,1,1 is a good approach. Please let me know if you have an idea how to handle this.
Also, if you will find anything else during review: please let me know.
This topic is connected with XCD-273.