Skip to content

fix pivotController position when explorer pane opens and closes#1921

Open
ahhhchuen wants to merge 2 commits intoxeokit:masterfrom
ahhhchuen:master
Open

fix pivotController position when explorer pane opens and closes#1921
ahhhchuen wants to merge 2 commits intoxeokit:masterfrom
ahhhchuen:master

Conversation

@ahhhchuen
Copy link
Contributor

Fix PivotController position when canvas proportion is modified by CSS.
This particularly affect the Xeokit BIM viewer, which implemented this PivotController feature that affected by explorer pane (left side) opening and closing.

@xeolabs
Copy link
Member

xeolabs commented Jul 17, 2025

Hi @ahhhchuen , could you please provide a minimal HTML page that embeds the BIMSurfer and reproduces this problem?

These CSS issues arise from various user's unanticipated page layouts, so fixing this for one user could break it for others, so this would be helpful to see if it's possible to include this PR.

thanks

@ahhhchuen
Copy link
Contributor Author

Isn’t BIMSurfer old?
I have no knowledge of it.
For problem reproduction , Xeokit BIM Vewer is enough:
https://xeokit.github.io/xeokit-bim-viewer/app/index.html?projectId=OTCConferenceCenter&tab=storeys

Just activate the explorer pane, spin the view point, then you’ll find the pivot point controller misplaced.

@xeolabs
Copy link
Member

xeolabs commented Jul 17, 2025

Isn’t BIMSurfer old? I have no knowledge of it. For problem reproduction , Xeokit BIM Vewer is enough: https://xeokit.github.io/xeokit-bim-viewer/app/index.html?projectId=OTCConferenceCenter&tab=storeys

Just activate the explorer pane, spin the view point, then you’ll find the pivot point controller misplaced.

Yes I mean't xeokit BIMViewer. I see now that the pivot misplacement occurs within BIMViewer without any fancy embedding, which we incorrectly assumed.

We need to see on our side if this fix interferes with other users applications, CSS layouts etc.

@ahhhchuen
Copy link
Contributor Author

by the way, do you have people caring xeokit BIM viewer repo? I have a PR there without response yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants