fix pivotController position when explorer pane opens and closes#1921
fix pivotController position when explorer pane opens and closes#1921ahhhchuen wants to merge 2 commits intoxeokit:masterfrom
Conversation
|
Hi @ahhhchuen , could you please provide a minimal HTML page that embeds the BIMSurfer and reproduces this problem? These CSS issues arise from various user's unanticipated page layouts, so fixing this for one user could break it for others, so this would be helpful to see if it's possible to include this PR. thanks |
|
Isn’t BIMSurfer old? Just activate the explorer pane, spin the view point, then you’ll find the pivot point controller misplaced. |
Yes I mean't xeokit BIMViewer. I see now that the pivot misplacement occurs within BIMViewer without any fancy embedding, which we incorrectly assumed. We need to see on our side if this fix interferes with other users applications, CSS layouts etc. |
|
by the way, do you have people caring xeokit BIM viewer repo? I have a PR there without response yet. |
Fix PivotController position when canvas proportion is modified by CSS.
This particularly affect the Xeokit BIM viewer, which implemented this PivotController feature that affected by explorer pane (left side) opening and closing.