fix(modules.editor): fix action menu for blocks and images#183
Merged
Conversation
…sition while it is open
|
ElizavetaAbramova
temporarily deployed
to
xi-development
GitHub Actions
Inactive
d9m0n4
reviewed
May 21, 2026
| ); | ||
| }; | ||
|
|
||
| function checkImageUrl(url: string): Promise<boolean> { |
Contributor
There was a problem hiding this comment.
стоит это вынести куда то в утилиты
d9m0n4
reviewed
May 21, 2026
| return ( | ||
| <DropdownMenu open={open} onOpenChange={setOpen} modal={false}> | ||
| <DropdownMenuTrigger asChild>{children({ open })}</DropdownMenuTrigger> | ||
| <DropdownMenu open={open} onOpenChange={setOpen} modal={true}> |
Contributor
There was a problem hiding this comment.
modal={true} можно явно не указывать, так по умолчанию true
d9m0n4
approved these changes
May 21, 2026
ElizavetaAbramova
temporarily deployed
to
xi-development
GitHub Actions
Inactive
ElizavetaAbramova
temporarily deployed
to
xi-development
GitHub Actions
Inactive
unknownproperty
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Функции во всплывающем меню работали лишь частично, теперь все функции работают корректно (в частности скачивание картинки, перемещение блока с помощью меню, применение форматирования к блоку)
Дополнительно: