Simplify implementation, add tests #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Sep 5, 2025
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_list_files() { |
There was a problem hiding this comment.
I added new tests
I verified these tests fail without the code changes in this PR
called `Result::unwrap()` on an `Err` value: ObjectStore(NotFound { path: "t", source: NoDataInMemory { path: "t" } })
thread 'url::tests::test_list_files' panicked at datafusion/datasource/src/url.rs:697:14:
called `Result::unwrap()` on an `Err` value: ObjectStore(NotFound { path: "t", source: NoDataInMemory { path: "t" } })
stack backtrace:
| } | ||
| } | ||
|
|
||
| async fn list_with_cache<'b>( |
There was a problem hiding this comment.
I moved this into its own function and simplified the implementation
|
Thanks for your detail review! These can help me a lot! @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing apache#17364 and had some ideas on how to improve it