Skip to content

xent-core: update, add runtimes config and dynamic xmake.lua#9242

Open
Crepveant wants to merge 2 commits intoxmake-io:devfrom
Project-Xent:dev
Open

xent-core: update, add runtimes config and dynamic xmake.lua#9242
Crepveant wants to merge 2 commits intoxmake-io:devfrom
Project-Xent:dev

Conversation

@Crepveant
Copy link

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Crepveant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the xent-core package definition by incorporating a new version and introducing a flexible runtimes configuration. The primary improvement lies in the dynamic generation of the xmake.lua file during installation, which allows for more adaptive build configurations based on user-defined settings, such as the compiler runtime library and the desired build kind (static or shared).

Highlights

  • New Version Added: A new version, 2026.02.01, has been added for the xent-core package, alongside its corresponding commit hash.
  • Configurable Runtimes: Introduced a new configuration option runtimes for xent-core, allowing users to specify the compiler runtime library, with a default value of "MD".
  • Dynamic xmake.lua Generation: The on_install function has been refactored to dynamically generate the xmake.lua content using string.format, enabling flexible runtime and build kind configurations.
  • Configuration Propagation: The runtimes configuration is now properly propagated to dependent packages, specifically yoga, ensuring consistent build settings across dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the xent-core package by adding a new version and making the xmake.lua generation in on_install more dynamic to support runtime configurations. However, the implementation introduces several issues: it removes critical logic for Windows shared library builds, breaks shared library builds on non-wasm platforms, and incorrectly configures a dependency. My review provides a revised on_install implementation that fixes these problems while retaining the intended dynamic behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant