-
-
Notifications
You must be signed in to change notification settings - Fork 509
Add xmake.lua for qt6quickcontrols2 package #9304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
std-microblock
commented
Feb 9, 2026
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
- 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。
Summary of ChangesHello @std-microblock, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new package definition for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new xmake package definition for qt6quickcontrols2. The implementation is solid and aligns well with the existing Qt6 packages. I have a couple of suggestions to improve maintainability and consistency, which are detailed in the comments below.
| set_kind("library") | ||
|
|
||
| on_load(function (package) | ||
| package:add("deps", "qt6quick", "qt6qml", "qt6gui", "qt6core", {debug = package:is_debug(), version = package:version_str()}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependencies qt6qml, qt6gui, and qt6core are transitive dependencies of qt6quick. You can simplify this declaration by only listing qt6quick as a direct dependency. This improves maintainability by relying on the dependency graph already defined in the qt6quick package.
package:add("deps", "qt6quick", {debug = package:is_debug(), version = package:version_str()})
| if package:is_plat("windows") then | ||
| cxflags = {"/Zc:__cplusplus", "/permissive-"} | ||
| else | ||
| cxflags = "-fPIC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, cxflags should always be a table of strings. The Windows-specific flags on line 15 are correctly defined as a table. This branch should do the same to ensure the cxflags variable has a consistent type, which is better practice even if xmake can handle a string value.
cxflags = {"-fPIC"}
Removed installation function for specific platforms.
| })) | ||
| end) | ||
|
|
||
| on_install("windows|x64,linux|x86_64,linux|arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? remove it. see other qt6xxx packages
| package:base():script("load")(package) | ||
| end) | ||
|
|
||
| on_test(function (package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move on_test to the bottom