node_crunch2: keep c++23

[luadebug]

#9273 (comment)

[gemini-code-assist]

Summary of Changes

Hello @luadebug, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the build configuration for the node_crunch2 package by uniformly adopting the C++23 standard. This change removes platform-specific conditional logic, ensuring a consistent and updated C++ environment for the package's compilation and testing.

Highlights

• C++ Standard Update: The required C++ standard for the node_crunch2 package has been updated from C++20 to C++23.
• Simplified Configuration: Conditional logic that previously set the C++ standard to C++20 by default and C++23 specifically for Windows has been removed, standardizing on C++23 for all platforms.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/n/node_crunch2/xmake.lua
  • Updated the language configuration for a check_cxxsnippets test from C++20 to C++23.
  • Removed conditional logic that dynamically set the C++ standard based on the operating system.
  • Modified a check_cxxsnippets call to explicitly use C++23 instead of a dynamically determined standard.

Activity

• No specific activity (comments, reviews, etc.) was found in the provided context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the C++ standard requirement for the node_crunch2 package to C++23. The changes are generally correct and enforce the new standard. However, I've identified one minor issue where an error message was not updated to reflect this change, which could cause confusion. I've provided a suggestion to fix it.

[luadebug]

For some reason android NDK failed to build on Windows OS host.

  => download https://github.com/openssl/openssl/archive/refs/tags/openssl-3.6.0.zip .. ok
checking for flags (-fPIC) ... ok
> clang.exe "-fPIC" "--sysroot=C:\Users\runneradmin\AppData\Local\.xmake\packages\n\ndk\27.3\2c4f5b0af31f46e4ac4b6db650a53855\toolchains\llvm\prebuilt\windows-x86_64\sysroot" "-isystem" "C:\Users\runneradmin\AppData\Local\.xmake\packages\n\ndk\27.3\2c4f5b0af31f46e4ac4b6db650a53855\toolchains\llvm\prebuilt\windows-x86_64\sysroot\usr\include\arm-linux-androideabi" "-Qunused-arguments" "--target=armv7-none-linux-androideabi30"
checking for flags (-fPIC) ... ok
> clang.exe "-fPIC" "-Qunused-arguments" "--target=armv7-none-linux-androideabi30" "--sysroot=C:\Users\runneradmin\AppData\Local\.xmake\packages\n\ndk\27.3\2c4f5b0af31f46e4ac4b6db650a53855\toolchains\llvm\prebuilt\windows-x86_64\sysroot" "-isystem" "C:\Users\runneradmin\AppData\Local\.xmake\packages\n\ndk\27.3\2c4f5b0af31f46e4ac4b6db650a53855\toolchains\llvm\prebuilt\windows-x86_64\sysroot\usr\include\arm-linux-androideabi"
checking for flags (-fPIC) ... ok
> clang++.exe "-fPIC" "--sysroot=C:\Users\runneradmin\AppData\Local\.xmake\packages\n\ndk\27.3\2c4f5b0af31f46e4ac4b6db650a53855\toolchains\llvm\prebuilt\windows-x86_64\sysroot" "-isystem" "C:\Users\runneradmin\AppData\Local\.xmake\packages\n\ndk\27.3\2c4f5b0af31f46e4ac4b6db650a53855\toolchains\llvm\prebuilt\windows-x86_64\sysroot\usr\include\arm-linux-androideabi" "-Qunused-arguments" "--target=armv7-none-linux-androideabi30"
checking for flags (-fPIC) ... ok
> clang++.exe "-fPIC" "-llog" "--target=armv7-none-linux-androideabi30" "-fPIE" "-pie" "-static-libstdc++" "-lc++abi" "-llog" "--target=armv7-none-linux-androideabi30" "-fPIE" "-pie" "-static-libstdc++" "-lc++abi"
checking for flags (-fPIC) ... ok
> clang++.exe "-fPIC" "-shared" "-llog" "--target=armv7-none-linux-androideabi30" "-static-libstdc++" "-lc++abi" "-llog" "--target=armv7-none-linux-androideabi30" "-static-libstdc++" "-lc++abi"
error: @programdir\core\sandbox\modules\os.lua:273: cannot runv(./Configure linux-armv4 no-shared --libdir=lib --openssldir=C:/Users/runneradmin/AppData/Local/.xmake/packages/o/openssl3/3.6.0/64986dd8313b48d08004bda7182f6e09 --prefix=C:/Users/runneradmin/AppData/Local/.xmake/packages/o/openssl3/3.6.0/64986dd8313b48d08004bda7182f6e09 threads), Unknown Error (193)
stack traceback:
    [C]: in function 'error'
    [@programdir\core\base\os.lua:1129]:
    [@programdir\core\sandbox\modules\os.lua:273]:
    [@programdir\core\sandbox\modules\os.lua:291]: in function 'vrunv'
    [D:\a\xmake-repo\xmake-repo\packages\o\openssl3\xmake.lua:259]: in function 'script'
    [...dir\modules\private\action\require\impl\utils\filter.lua:114]: in function 'call'
    [...\modules\private\action\require\impl\actions\install.lua:480]:

  => install openssl3 3.6.0 .. failed
error: @programdir\core\main.lua:274: @programdir\modules\async\runjobs.lua:261: ...\modules\private\action\require\impl\actions\install.lua:592: install failed!
stack traceback:
    [C]: in function 'error'
    [@programdir\core\base\os.lua:1129]:
    [...\modules\private\action\require\impl\actions\install.lua:592]: in function 'catch'
    [@programdir\core\sandbox\modules\try.lua:123]: in function 'try'
    [...\modules\private\action\require\impl\actions\install.lua:447]:
    [...modules\private\action\require\impl\install_packages.lua:514]: in function 'job_func'
    [@programdir\modules\async\runjobs.lua:441]:

stack traceback:
	[C]: in function 'error'
	@programdir\core\base\os.lua:1129: in function 'base/os.raiselevel'
	(...tail calls...)
	@programdir\core\main.lua:274: in upvalue 'cotask'
	@programdir\core\base\scheduler.lua:514: in function <@programdir\core\base\scheduler.lua:507>