Update rows statuses of "hidden" and "disabled" after adding all rows#370
Open
su23 wants to merge 1 commit intoxmartlabs:masterfrom
Open
Update rows statuses of "hidden" and "disabled" after adding all rows#370su23 wants to merge 1 commit intoxmartlabs:masterfrom
su23 wants to merge 1 commit intoxmartlabs:masterfrom
Conversation
Member
|
Hi @su23 I think this does not fix the real problem. Suppose the following case: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have some complex dependency between rows (for example in row A visibility is depended on the value of row B which is located below row A) then you need to have an access to this row (which may not exists in the UI at that moment). Thus, the "visibility" or "disable" status of row A is not right.
In my change I split the logic of row adding and updating phases. Thus, in the first step we add all rows to the section and only after that evaluate "hidden" and "disable" rules for each added row.