[Feat] Add setup completion tracking to prevent multiple setup calls #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
�� Type of change:
✏️ Description:
This PR added setup completion tracking to prevent multiple calls to the LINE SDK setup function. Fixes #186
Problem: The LINE SDK setup function could be called multiple times, causing app crashes or unexpected behavior due to internal SDK errors that developers couldn't properly handle.
Solution: Modified the setup method to check the existing
LoginManager.shared.isSetupFinished
property and reject with a clear error message when setup is already completed. This allows developers to handle the situation properly in the JavaScript layer instead of experiencing app crashes.Key Changes:
reject("SETUP_ALREADY_COMPLETED", "Setup has already been completed", nil)
when setup is already finishedAcceptance criteria:
🎥 Screen record:
N/A - This is a backend fix that doesn't require UI changes.
📌 Notes:
isSetupFinished
instead of adding new variables✔️Tasks:
LoginManager.shared.isSetupFinished
SETUP_ALREADY_COMPLETED
error will need to add try-catch blocks