Skip to content

Don't allow pings to prevent timeout #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

singpolyma
Copy link
Contributor

Sending a new request shouldn't clear the waiting-for-reply timeout if we haven't got a reply yet, or else we may never time out at all if we keep sending pings (which we do).

Copy link
Member

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@singpolyma
Copy link
Contributor Author

fixed the test

Sending a new request shouldn't clear the waiting-for-reply timeout if
we haven't got a reply yet, or else we may never time out at all if we
keep sending pings (which we do).
@sonnyp
Copy link
Member

sonnyp commented Jun 11, 2025

Tests should be updated so that a test would fail before the fix and pass after the fix. The best way to do that is to add a new test that describes the issue for example "Pings do not preven timeouts"

@singpolyma
Copy link
Contributor Author

Tests should be updated so that a test would fail before the fix and pass after the fix.

Yes, that's what I did. The test previously had a too-long interval so it was over before this case would even trigger and so would pass. As now written it fails without this change and passes with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants