Hotfixes json #400
Merged
Hotfixes json #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| end | ||
|
|
||
| def apply_selects | ||
| @xrons = @xrons.select(*@selects).distinct |
Check failure
Code scanning / CodeQL
SQL query built from user-controlled sources High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To prevent SQL injection, untrusted data from the user must be validated/sanitized before being used in the .select(*@selects) call. The best fix is to implement a whitelist of allowed column names, and reject or ignore anything outside this list.
- In
app/controllers/xronos_data_controller.rb, define a constant (for example,ALLOWED_SELECT_COLUMNS) that lists permitted column names. - Change the
select_paramsmethod to filter incoming parameters and only permit keys/values within that whitelist. - This will ensure that only safe, known columns are ever sent to the model and splatted into the SQL
SELECT. - Changes are required in the
select_paramsmethod inXronosDataController, only on the code shown.
Suggested changeset
1
app/controllers/xronos_data_controller.rb
Outside changed files
| @@ -141,9 +141,12 @@ | ||
|
|
||
| private | ||
|
|
||
| # Only allow known, safe columns through 'select' param | ||
| ALLOWED_SELECT_COLUMNS = %w[ | ||
| id name lng lat | ||
| # Add whatever other columns you wish to permit | ||
| ].freeze | ||
| # --------------------------- | ||
| # Helpers for caching | ||
| # --------------------------- | ||
|
|
||
| def unfiltered_request? | ||
| filter_params.blank? && select_params.blank? | ||
| @@ -249,8 +251,11 @@ | ||
| ) | ||
| end | ||
|
|
||
| # TODO: is this safe??? | ||
| # Filter select params: only allow whitelisted columns | ||
| def select_params | ||
| params.fetch(:select, {}) | ||
| select = params.fetch(:select, {}) | ||
| # if select param is hash (e.g., from checkboxes), get values; if array, use directly | ||
| select_values = select.is_a?(Array) ? select : select.values | ||
| select_values.select { |col| ALLOWED_SELECT_COLUMNS.include?(col.to_s) } | ||
| end | ||
| end |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of speed improvements and some opening up json endpoints