Fixed Visual bug with hovering links and scrolling#5029
Open
Skinbow wants to merge 6 commits intoxtermjs:masterfrom
Open
Fixed Visual bug with hovering links and scrolling#5029Skinbow wants to merge 6 commits intoxtermjs:masterfrom
Skinbow wants to merge 6 commits intoxtermjs:masterfrom
Conversation
Author
|
Hello. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I managed to remove a visual bug with link hover underlines staying after scrolling upwards, as the link would not be refreshed when it went off-screen.
I used the assumption from the previous line (from the one where I made the change) where e.start is 0 if a scroll occurred.
I first encountered this bug on vscode.
It normally fixes microsoft/vscode#207956
I am unsure whether it fixes #4661 as I do not know how to check the change directly on vscode.
Thank you for your time and consideration.