Skip to content

feat(whitespace): allow css property whitespace: pre - #333

Merged
HackbrettXXX merged 5 commits into
yWorks:masterfrom
Fuzzyma:allow-whitespace-pre
Sep 16, 2025
Merged

HackbrettXXX merged 5 commits into
yWorks:masterfrom
Fuzzyma:allow-whitespace-pre

Conversation

@Fuzzyma

@Fuzzyma Fuzzyma commented Aug 26, 2025 •

Copy link
Copy Markdown
Contributor

For now, this works exactly like xml-space: preserve. It does not support line breaks.

Let me know, if i missed anything

One test was failing for me (group-fill-rule). Not sure where this is coming from

For now, this works exactly like xml-space: preserve. It does not support line breaks.
@Fuzzyma

Fuzzyma commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

It seems that one of the builds fails the test and the other one passes it.
I looked at the references and in one case, all whitespaces are stripped. So eitehr the build is not correctly building and it uses the old version or i need to commit the build so that it is used in the ci or i dont know what.

Any help is appreciated.

PS: I have trouble setting up this project with yarn. Last time i ended up using npm because yarn wouldnt run the tests for me.
This time, I get some error while building. Would be nice to switch package managers to something that just works

@HackbrettXXX

Copy link
Copy Markdown
Member

The code looks good. I think you only need to update the reference file. You can find the correct one in the artifacts of the last build.

I agree that the package manager and test situation is a bit of a mess currently. We probably should just get rid of yarn support and stick with npm. Also, we probably don't need a UMD build at this point anymore, making the test-globals, test-amd and test-cjs scripts obsolete. But that's not high priority for me. If you have time, I'll be happy to merge/review a PR.

@Fuzzyma

Fuzzyma commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

I did update the reference for the new test but the ci is failing on the new test.
I think its using the old dist files because i usually dont commit dist files. Should I go ahead and do that?

@HackbrettXXX

Copy link
Copy Markdown
Member

The reference you checked in is wrong. The code produces the correct output, so just update the reference.

@HackbrettXXX
HackbrettXXX merged commit ca02c06 into yWorks:master Sep 16, 2025
1 check passed
@Fuzzyma

Fuzzyma commented Sep 17, 2025 •

Copy link
Copy Markdown
Contributor Author

Sorry for not getting back on this really!
I promise I would have eventually!! 😂

Thanks for taking care of it!

@HackbrettXXX

Copy link
Copy Markdown
Member

No worries. I've released the changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants