Repository navigation
feat(whitespace): allow css property whitespace: pre - #333
Conversation
For now, this works exactly like xml-space: preserve. It does not support line breaks.
|
It seems that one of the builds fails the test and the other one passes it. Any help is appreciated. PS: I have trouble setting up this project with yarn. Last time i ended up using npm because yarn wouldnt run the tests for me. |
|
The code looks good. I think you only need to update the reference file. You can find the correct one in the artifacts of the last build. I agree that the package manager and test situation is a bit of a mess currently. We probably should just get rid of yarn support and stick with npm. Also, we probably don't need a UMD build at this point anymore, making the test-globals, test-amd and test-cjs scripts obsolete. But that's not high priority for me. If you have time, I'll be happy to merge/review a PR. |
|
I did update the reference for the new test but the ci is failing on the new test. |
|
The reference you checked in is wrong. The code produces the correct output, so just update the reference. |
|
Sorry for not getting back on this really! Thanks for taking care of it! |
|
No worries. I've released the changes now. |
For now, this works exactly like xml-space: preserve. It does not support line breaks.
Let me know, if i missed anything
One test was failing for me (group-fill-rule). Not sure where this is coming from