Repository navigation
Fix drop all-zero stroke-dasharray patterns - #383
Closed
amandeavor wants to merge 1 commit into
Closed
amandeavor wants to merge 1 commit into
amandeavor wants to merge 1 commit into
Conversation
PDF rejects dash patterns of all zeroes (Acrobat errors). In SVG, stroke-dasharray="0 0" is equivalent to a solid stroke, so treat it as absent instead of calling setLineDashPattern([0, 0], …). Fixes yWorks#343
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stroke-dasharray="0.00 0.00"(and other all-zero patterns) is valid-ish in SVG as a solid stroke, but invalid in PDF — Acrobat errors on it. Maintainer note on #343: a small guard here is OK.Change
0, leavestrokeDasharrayunset (solid stroke) instead of callingsetLineDashPattern([0, 0], …)isEffectivelySolidDashArrayFixes #343
Validation
npm run formatnpm run typechecknpm run lintnpx vitest run test/parsing/parsing.spec.ts— 6 passed