Export alt values in hooks and bootstrap#312
Open
erijo wants to merge 2 commits intoyadm-dev:developfrom
Open
Conversation
kgadek
added a commit
to kgadek/yadm-bin
that referenced
this pull request
Feb 21, 2021
Upstream issue: yadm-dev#291 Upstream PR: yadm-dev#312
kgadek
added a commit
to kgadek/yadm-bin
that referenced
this pull request
Aug 8, 2021
Upstream issue: yadm-dev#291 Upstream PR: yadm-dev#312
kgadek
added a commit
to kgadek/yadm-bin
that referenced
this pull request
Dec 2, 2021
Upstream issue: yadm-dev#291 Upstream PR: yadm-dev#312
local_class -> YADM_CLASS local_system -> YADM_OS local_host -> YADM_HOSTNAME local_user -> YADM_USER local_distro -> YADM_DISTRO The new names match the names used for j2/esh templates.
kgadek
added a commit
to kgadek/yadm-bin
that referenced
this pull request
Apr 17, 2022
Upstream issue: yadm-dev#291 Upstream PR: yadm-dev#312
kgadek
added a commit
to kgadek/yadm-bin
that referenced
this pull request
Apr 20, 2023
Upstream issue: yadm-dev#291 Upstream PR: yadm-dev#312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename the
local_*variables toYADM_*and export them so that hooks and bootstrap can use them.What issues does this PR fix or reference?
Previous Behavior
Hooks and bootstrap had to come up with other ways to get the info.
New Behavior
Now they can just use
YADM_*from the environment.Have tests been written for this change?
Yes (a basic one)
Have these commits been signed with GnuPG?
Yes
Please review yadm's Contributing Guide for best practices.