support addexecutionprovider #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalue
reviewed
May 21, 2025
There was a problem hiding this comment.
The change looks great, and I should have done this a long time ago. In fact, after merging this I'll go and look for other places where this can be used. Just requested a few changes to the comments; most importantly the documentation for the new AppendExecutionProvider function.
| return nil | ||
| } | ||
|
|
||
| // TODO: Descripiton. Enables the QNN and SNPE backends for the given session options on supported |
There was a problem hiding this comment.
Update the documentation comment to something more generic.
| // map. | ||
| func (o *SessionOptions) AppendExecutionProvider(provider_name string, | ||
| options map[string]string) error { | ||
| // There's probably a more concise way to do this, but we don't want to |
There was a problem hiding this comment.
This comment doesn't need to be repeated here, since I already had it in other places.
|
@kubaraczkowski Can you fix this and get merged? I was thinking to do the same thing but I saw it here already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap calls to AppendExecutionProvider, so e.g. QNN can be used.
https://onnxruntime.ai/docs/execution-providers/QNN-ExecutionProvider.html