Skip to content

FND-1551: UPDATE all optional attributes should be allowed to be omitted #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FND-1551: UPDATE all optional attributes should be allowed to be omitted #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions charts/base/templates/_keda.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,12 @@ spec:
{{- if .Values.keda.scaleTargetRef.envSourceContainerName }}
envSourceContainerName: {{ .Values.keda.scaleTargetRef.envSourceContainerName }}
{{- end }}
pollingInterval: {{ .Values.keda.pollingInterval | default 30 }}
cooldownPeriod: {{ .Values.keda.cooldownPeriod | default 300 }}
{{- if .Values.keda.pollingInterval }}
Copy link
Contributor

@juriku juriku Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem with those that keda will set default values regardless, therefore it might be misleading to make it optional

Copy link
Contributor Author

@mattclegg mattclegg Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I want the keda defaults & not predefined defaults. It adds more complexity as it has a default value here & a default value in values.yaml & neither are needed.

Copy link
Contributor

@juriku juriku Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier to manage them with helm, because if you remove them, then they still will be there

Copy link
Contributor Author

@mattclegg mattclegg Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't want them there. The purpose of the PR is to only set them when they're defined.

pollingInterval: {{ .Values.keda.pollingInterval }}
{{- end }}
{{- if .Values.keda.cooldownPeriod }}
cooldownPeriod: {{ .Values.keda.cooldownPeriod }}
{{- end }}
{{- if .Values.keda.idleReplicaCount }}
idleReplicaCount: {{ .Values.keda.idleReplicaCount }}
{{- end }}
Expand Down