Patch vulnerable dependencies across yDaemon - #568
Open
murderteeth wants to merge 4 commits into
Open
Conversation
Require Go 1.26.8 for local and production builds, use go.mod for CI toolchain selection, and update the Docker build image. Build without rewriting the dependency graph inside the image. Verified that the existing application builds with Go 1.26.8. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Update Ethereum, PostgreSQL, CORS and WebSocket libraries, along with Go networking, cryptography, text and OpenTelemetry dependencies. Replace removed geth integer constants with the standard math package. Add API and generated ERC-20 binding regression checks, including HTTP and WebSocket transport and historical calls with large integers. Build and focused tests pass. Govulncheck reports no vulnerable imported packages or called symbols; unused OpenPGP retains an unpatched advisory. The full suite has the same two pre-existing test compilation failures. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Upgrade Ajv and its format plugin. Use the existing address helper instead of importing the full ethers SDK, and remove unused Cloudflare and Codeowners dependencies. Pin patched bn.js and CMS WebSocket versions through overrides and refresh both Bun lockfiles. Both Bun audits, frozen installs, token/vault validation, CMS type checking, and a patched WebSocket client/server smoke test pass. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Update PyCryptodome and eth-utils, and document the Python 3.10 minimum. The newer eth-utils also removes its obsolete pkg_resources import. Add EIP-55 vectors and an invalid-checksum case to verify compatibility. Checksum unit tests and pip-audit pass. The legacy full metadata walk still assumes the old strategy JSON shape and raises KeyError. Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
murderteeth
marked this pull request as ready for review
September 8, 2026 01:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Go toolchain and vulnerable dependencies across the API and metadata tooling. The resulting versions fall outside the affected ranges of all 37 Dependabot alerts reviewed on September 7; GitHub will need to rescan after merge to close them.
The changes are split into four commits:
go.mod.bn.jsand CMSwsversions and refresh both Bun lockfiles.How to review
Review the commits in order. Focus on the resolved Go dependency graph, the two integer-constant import changes, and the JavaScript dependency removals/overrides. The new Go tests exercise API JSON/CORS behavior and generated ERC-20 bindings over HTTP and WebSocket, including historical calls and large integer values.
Test plan
go mod verify.govulncheck -show verbose ./...: no vulnerable called symbols or imported packages.common/ethereumandexternal/vaultsstill have the same test compilation failures reproduced before the dependency upgrades (missing PPS arguments and obsoleteTStrategyreferences).Legacy full metadata walkers also assume obsolete snapshot shapes (
addresses/ per-file$schema); current CI validators and the focused checksum tests pass.Risk / impact
The main compatibility risk is the coordinated Ethereum/PostgreSQL dependency upgrade; local transport tests cover bindings, while live indexing and database behavior still need review. Builds now require Go 1.26.8, and Python validation requires Python 3.10+.
govulncheckretains one module-only advisory, GO-2026-5932, for deprecatedx/crypto/openpgp. The application does not import that package, and the advisory has no patched version.