Convert file path returned from LSP in Cygwin #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegappan
reviewed
Jan 3, 2024
| uri_decoded = uri_decoded->substitute('/', '\\', 'g') | ||
| if has("win32unix") # we're in Cygwin | ||
| # The substitution is to remove the '^@' escape character from the end of line. | ||
| uri_decoded = system($'cygpath --unix {uri_decoded}')->substitute('^\(\p*\).*$', '\=submatch(1)', "") |
Owner
There was a problem hiding this comment.
Invoking an external command for decoding every URI may incur a lot of overhead. Is cygpath used to only the '^@' character from the end of the line? Is it possible to remove it using trim()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion in the other direction is performed below, in
LspFileToUrifunction. This direction was missing and this PR adds that.