Fix null being stored instead of null when using deep path #1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
reviewed
Sep 23, 2025
|
|
||
| for (const [name, questionStorage] of Object.entries(storageForQuestion)) { | ||
| const answer: any = answers[name] === undefined ? null : answers[name]; | ||
| const answer: any = _.get(answers, name, null); |
There was a problem hiding this comment.
Is inquirer lodash aware too?
If not it may cause issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request?
What changes did you make?
When using a question name containing a dot (like
foo.bar) the answers are returned as keys in an object ({ foo: { bar: 'answer' } }), this meansanswers[name]will be undefined andnullwill be stored in storage instead of the correct answer.This PR fix it by using lodash's
getto get the correct value from the answers.