Vendoring gloo-workers into yew-agent - #3859
Merged
Madoshakalaka merged 6 commits intoMay 20, 2025
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit bf301e3): https://yew-rs-api--pr3859-vendoring-yew-agent-dbqx7kad.web.app (expires Tue, 20 May 2025 14:58:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Madoshakalaka
approved these changes
May 20, 2025
Madoshakalaka
left a comment
Member
There was a problem hiding this comment.
This seems much wanted and all reviews were addressed in the old PR. Thanks for the contribution.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given the nearly-archived state of the underlying
gloo-workerscrate, after a chat with @Madoshakalaka, we determined to fold gloo-workers intoyew-agentso to add support for things such as WebWorkers with typemodule, as this relatively old PR tried to do for gloo: ranile/gloo#421In this PR, I have:
module-typed WebWorker, optionallymoduleproperty toWorkerProvider,ReactorProviderandOneshotProviderWhile in the original PR the type
modulewas made the default one, I have decided to leave the current default one and allow the user to set it with theas_module(bool)method.Best,
Luca