[cmake] Allow using pre-existing zstd target if it exists #2390
Open
crueter wants to merge 1 commit intoyhirose:masterfrom
Open
[cmake] Allow using pre-existing zstd target if it exists #2390crueter wants to merge 1 commit intoyhirose:masterfrom
crueter wants to merge 1 commit intoyhirose:masterfrom
Conversation
Owner
|
@sum01 @jimmy-park @Tachi107 could you please check the pull request? If it looks good, I'll merge it. Thanks! |
sum01
reviewed
Mar 14, 2026
Owner
|
@crueter any response? |
yhirose
force-pushed
the
master
branch
2 times, most recently
from
170f122 to
a9359df
Compare
adds support for pre-existing `zstd::libzstd` which is useful for projects that bundle their own zstd in a way that doesn't get caught by `CONFIG` Signed-off-by: crueter <crueter@eden-emu.dev>
crueter
force-pushed
the
fix-zstd-already-found
branch
from
509be32 to
fc473b3
Compare
crueter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for pre-existing
zstd::libzstdwhich is useful forprojects that bundle their own zstd in a way that doesn't get caught by
CONFIGSigned-off-by: crueter crueter@eden-emu.dev