Swarm deploy: prune containers and do not detach #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the production deployment command for Docker Swarm by adding container pruning and synchronous deployment behavior. The changes ensure that obsolete containers are removed during deployment and that the deployment process waits for completion before returning control.
- Added
--pruneflag to remove services that are no longer defined - Added
--detach=falseto make the deployment wait for completion - Both flags improve deployment reliability and observability
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
============================================
- Coverage 77.22% 76.96% -0.26%
Complexity 29 29
============================================
Files 11 11
Lines 180 178 -2
============================================
- Hits 139 137 -2
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--prunemakes removing unused container that are no longer in the stack.--detach=falsemake the command actually get the output from the Docker Swarm about how actual deployment goes and errors if any. Previously it was existing with success as long as compose file was sent.