Add function_exists() checks for PCNTL functions #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
approved these changes
Apr 15, 2021
|
@samdark Already done :) |
samdark
approved these changes
Apr 16, 2021
|
Merged. Thanks. We should really fix the build pipeline here :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a couple customers running Craft CMS on hosts that have the PCNTL extension installed, but its functions are listed in
disabled_functions, so they get PHP errors when running the queue.This PR enhances the
extension_loaded('pcntl')checks with specific checks to see if its functions also exist. We’ve verified that it fixes the PHP errors.