Eager loading in ActiveRecord::refresh() (without breaking BC) #20290
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ use array_column for faster mapping if no callbacks or grouping are required
+ changelog
+ also test with callbacks
! don't use array_column if ArrayHelper strings are paths + add according tests + add BaseStringHelper::contains() helper function and according tests
o code style fixes
! use strpos rather than polyfill - remove BaseStringHelper::contains
+ implementation with BC break
+ BC safe implementation
+ changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20290 +/- ##
=========================================
Coverage 64.85% 64.85%
- Complexity 11409 11411 +2
=========================================
Files 431 431
Lines 37142 37145 +3
=========================================
+ Hits 24087 24090 +3
Misses 13055 13055 ☔ View full report in Codecov by Sentry. |
| foreach ($this->getPrimaryKey(true) as $key => $value) { | ||
| $pk[$tableName . '.' . $key] = $value; | ||
| } | ||
| $args = func_get_args(); |
There was a problem hiding this comment.
I think passed arguments must be compatible with with():
$args = func_get_args();
if ($args) {
$query->with(...$args);
}| /** | ||
| * {@inheritdoc} | ||
| * | ||
| * @param array $with If an array is passed to this function, |
There was a problem hiding this comment.
you can't be declared it as required parameter $with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll post a breaking but prettier implementation (for 2.2.x) in a separate pull request.