Skip to content

Conversation

mspirkov
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

The ESLint configuration was added here: #12452
Then Codeclimate was removed here: #20572
It seems that these files are no longer needed. It might be worth adding ESLint in separate request and adding a new configuration for it.

@samdark
Copy link
Member

samdark commented Oct 13, 2025

I think ESLint is automatically used by IDEs/editors and the config matches the code style used with Yii2.

@mspirkov
Copy link
Contributor Author

mspirkov commented Oct 13, 2025

It seems that this will only work if ESLint is installed globally, as it is not available in this repository. You also need an older version of ESLint that supports this configuration.

image

I still think that it is necessary to install a new version of ESLint and add a configuration for it. It is also worth adding an ESLint check to the CI

@mspirkov
Copy link
Contributor Author

I can do it in this PR if it's better.

@mspirkov mspirkov changed the title Remove ESLint files Remove old ESLint files Oct 13, 2025
@mspirkov mspirkov marked this pull request as draft October 13, 2025 12:17
@mspirkov mspirkov changed the title Remove old ESLint files Add ESLint to CI Oct 13, 2025
@mspirkov
Copy link
Contributor Author

mspirkov commented Oct 13, 2025

I ran ESLint with the old configuration and got 60 errors in framework/assets. I'll change it a bit so there are no errors.

image

@mspirkov
Copy link
Contributor Author

I have reduced the level of these errors and limited their number. It would be great to correct them in the future.

image

@mspirkov mspirkov marked this pull request as ready for review October 13, 2025 13:01
@mspirkov
Copy link
Contributor Author

@terabytesoftw @samdark Please take another look

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samdark samdark merged commit d689d61 into yiisoft:master Oct 14, 2025
94 checks passed
@samdark
Copy link
Member

samdark commented Oct 14, 2025

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants