-
Notifications
You must be signed in to change notification settings - Fork 1
[TEST]Autoround version test #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yiliu30 <[email protected]>
Signed-off-by: yiliu30 <[email protected]>
…mpressor-fork into autoround-version
Signed-off-by: yiliu30 <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @yiliu30, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the integration and stability of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the auto-round dependency to a pinned version and adapts the AutoRoundModifier to the new version's API. The changes include pinning auto-round to version 0.9.1 in setup.py, adding a batch_size parameter to AutoRoundModifier, and ensuring the device parameter is passed as a string. The changes are correct and improve dependency management and fix compatibility issues. I've added a couple of suggestions to improve code documentation and clarity for future maintenance.
| # AutoRound modifier arguments | ||
| iters: int = 200 | ||
| enable_torch_compile: bool = True | ||
| batch_size: int = 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| inputs=cur_inputs, | ||
| q_input=self._q_input, | ||
| device=device, | ||
| device=str(device), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change to cast device to a string is a necessary fix. To improve code clarity for future maintainers, it would be helpful to add an inline comment explaining why this cast is needed, as the underlying auto-round library's expectation of a string is not immediately obvious.
| device=str(device), | |
| device=str(device), # auto-round expects device as a string |
SUMMARY:
"please provide a brief summary"
TEST PLAN:
"please outline how the changes were tested"