Conversation
There was a problem hiding this comment.
Pull request overview
Updates the streaming UI rendering in sig for the v0.3.0 release by introducing a terminal layout model (pane + stream regions), adjusting how streaming output is drawn, and aligning terminal mode setup/teardown.
Changes:
- Refactors terminal rendering to maintain explicit
(width, height)and pane-row layout, with scroll-region based streaming output. - Updates streaming loop to sync terminal layout on resize and split pane redraw vs stream drawing.
- Enables/disables mouse capture alongside raw mode and cursor visibility; bumps crate version and adjusts
profile.distoptimizations.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/terminal.rs |
Replaces anchor-based drawing with size/pane-row layout, adds scroll-region handling, and separates pane vs stream drawing APIs. |
src/sig.rs |
Adapts streaming rendering to new Terminal APIs, including layout syncing and separate pane/stream draws. |
src/main.rs |
Enables mouse capture during raw-mode operation and disables it on shutdown. |
Cargo.toml |
Bumps version to 0.3.0 and changes profile.dist to codegen-units = 1 + lto = true. |
Cargo.lock |
Updates locked package version to 0.3.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove archive mode (means remove `-a, --archived` options)
docs: terminal.rs
Ctrl+S: pause/start for streaming
Pane for hinting
Enable to customize keybinds and styles
Bump up `promkit` version to v0.11.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
-a,--archived