Ctrl+S: pause/start for streaming#21
Merged
ynqa merged 2 commits intov0.3.0/devfrom Feb 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a streaming pause/resume toggle to sig so users can temporarily stop (and restart) ingesting new lines during streaming mode.
Changes:
- Introduces a new Ctrl+S keybinding to toggle paused state during streaming.
- Implements pause signaling between the UI loop and the stream-ingestion/render task via a
tokio::sync::watchchannel. - Documents the new keybinding in the README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/sig.rs |
Adds Ctrl+S handling and a watch-channel-driven pause mechanism in the streaming ingestion/render loop. |
README.md |
Documents Ctrl+S as Pause/Resume for stream ingestion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+193
to
+196
| if queue.len() > queue_capacity { | ||
| queue.pop_front().unwrap(); | ||
| } | ||
| queue.push_back(line.clone()); |
There was a problem hiding this comment.
The queue-size limiting condition allows the queue to temporarily grow to queue_capacity + 1 because it only pops when len() > queue_capacity and then immediately pushes. If queue_capacity is intended as a strict max retained lines, this should pop when len() >= queue_capacity (and handle queue_capacity == 0 explicitly).
Suggested change
| if queue.len() > queue_capacity { | |
| queue.pop_front().unwrap(); | |
| } | |
| queue.push_back(line.clone()); | |
| if queue_capacity > 0 { | |
| if queue.len() >= queue_capacity { | |
| queue.pop_front().unwrap(); | |
| } | |
| queue.push_back(line.clone()); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.