Skip to content

Conversation

GL1TCH1337
Copy link
Contributor

@GL1TCH1337 GL1TCH1337 commented Apr 24, 2024

I have removed player chat event based command system and integrated it to CS# command system. By doing this players can change prefix of command by CS# settings and no need to add different prefixes to this plugin config.

This also completely solves issue #128

Since this is a big change. Server owners should configure their config by new default config.

Waiting your feedbacks.

@yonilerner
Copy link
Owner

I need some time to think about this. Im not sure this is really necessary, maybe I'm not understanding though

Copy link
Collaborator

@oqyh oqyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing StringComparison.OrdinalIgnoreCase

will force people !gunmenu
and will ignore !GuNMenu !GUNMENU

it will lead to open this issue again
#45

not good

@yonilerner
Copy link
Owner

This PR is more "standard" but it gives less flexibility to the commands themselves, so Im hesitant to change it. Does CS# support case insensitive commands maybe?

@GL1TCH1337
Copy link
Contributor Author

GL1TCH1337 commented Apr 26, 2024

CS# command system commands work case insensitive. It will work anyways. !GuNs or !GUNS dont matter.

(another plugin of me but uses cs# command system)

image
image
image

@oqyh
Copy link
Collaborator

oqyh commented Apr 26, 2024

CS# command system commands work case insensitive. It will work anyways. !GuNs or !GUNS dont matter.

(another plugin of me but uses cs# command system)

image image image

you removing "gunmenu" ".gunmenu" some people want it without !

@oqyh
Copy link
Collaborator

oqyh commented Apr 26, 2024

if you want to solve
#128
you can just change

if (CenterMenuCommands.Any(cmd => cmd.Equals(message, StringComparison.OrdinalIgnoreCase)))
to
if (CenterMenuCommands.Any(cmd => cmd.Equals(message.TrimStart('/'), StringComparison.OrdinalIgnoreCase)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants