Open
Conversation
Contributor
Author
|
@z-x-yang Can you please review it, and review the PRs in the other repository as well, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pytorch >= 2.6 version, the torch.load function basically refuses to load the pickled ones due to safety reasons
So, I have introduced a parameter inside the function as weights_only = False, with this, the execution is safer, as the .pth file contains not only weights but other things like optimizer and state dicts, so setting weights only to false help the loading of the pickled objects for pytorch newer versions
The older versions (while I was experimenting on jetson device) gave me warnings, now with the pytorch update the warning turned to an error