Skip to content

Changing :sim to :simlayer-threshold - #96

Open
johnlindquist wants to merge 1 commit into
yqrashawn:masterfrom
johnlindquist:patch-1
Open

Changing :sim to :simlayer-threshold#96
johnlindquist wants to merge 1 commit into
yqrashawn:masterfrom
johnlindquist:patch-1

Conversation

@johnlindquist

Copy link
Copy Markdown

I see a lot of examples on github, etc using :sim in the config, but it doesn't change anything. :simlayer-threshold is what works.

:sim also appears in some of the tests, but I'm not confident enough in updating those 😬

I see _a lot_ of examples on github, etc using `:sim` in the config, but it doesn't change anything. `:simlayer-threshold` is what works.

`:sim` also appears in some of the tests, but I'm not confident enough in updating those 😬
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 305

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.284%

Totals Coverage Status
Change from base Build 304: 0.0%
Covered Lines: 1160
Relevant Lines: 1329

💛 - Coveralls

@nikivdev

Copy link
Copy Markdown
Contributor

but it doesn't change anything

It changes things for me.

CleanShot 2020-11-24 at 10 34 25@2x

@johnlindquist

Copy link
Copy Markdown
Author

@nikitavoloboev For my karabiner.json file, simlayer-threshold updates where the threshold is defined in the rules (but not the parameters you're showing):

          "parameters" : {
            "basic.simultaneous_threshold_milliseconds" : 250
          },

As a test, set:

:sim 999

then search for 999 in your karabiner.json. Mine gives zero results.

then set:

:simlayer-threshold 999

and search for 999 again. Mine shows all the threshold values updated to 999.

@yqrashawn

Copy link
Copy Markdown
Owner

the :sim one is to set the default basic.simultaneous_threshold_milliseconds.
image

the :simlayer-threshold will override the above one in each rule in the parameters.basic.simultaneous_threshold_milliseconds
image

the second one is for setting the global basic.simultaneous_threshold_milliseconds before the profile feature (which added the :sim)

related issue comment #29 (comment)

@yqrashawn
yqrashawn force-pushed the master branch 22 times, most recently from 47ad770 to c3e3214 Compare January 13, 2021 07:23
@yqrashawn
yqrashawn force-pushed the master branch 2 times, most recently from cb62026 to 4e173a4 Compare February 20, 2021 10:43
@eugenesvk

Copy link
Copy Markdown
Contributor

Just got bitten by these testing simultaneous keys.
Just to clarify: will this PR remove individual key parameters (currently hardcoded to 250 or overridden to another value with :simlayer-threshold 240) so that these keys will be able to read the global default values? I basically don't want any key combo to have this parameter unless it was explicitly specified in the key definition

Even the :simlayer-threshold option isn't great as it's confusing for the global settings in karabiner UI to be ignored, you have to remember that it's embedded in each key and can only be fixed via Goku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants