Skip to content

[CLOUDGA-26718] Improve error message for clone to point in time without existing PITR config #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshitha-yb merged 1 commit into from
Mar 25, 2025
+2 −2
Merged

[CLOUDGA-26718] Improve error message for clone to point in time without existing PITR config #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/cluster/pitr-config/pitr_config_ops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ var clonePitrConfigCmd = &cobra.Command{
// No PITR config exists, so we create one and clone to current time.
// "clone-at-millis" argument should not be provided in this case.
if cmd.Flags().Lookup("clone-at-millis").Changed {
logrus.Fatalf("A PITR Config doesn't exist for %s namespace %s in cluster %s. So clone-at-millis parameter must not be specified\n", namespaceType, namespaceName, ClusterName)
logrus.Fatalf("No PITR configuration found for %s namespace %s in cluster %s. The 'clone-at-millis' parameter cannot be used unless a valid PITR configuration is set up.\n", namespaceType, namespaceName, ClusterName)
}
cloneSpec.SetCloneNow(*ybmclient.NewDatabaseCloneNowSpec(namespaceId, cloneAs))
} else {
Expand Down
2 changes: 1 addition & 1 deletion cmd/pitr_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ test_ycql_db YCQL 6 ACTIVE 123456
Expect(err).NotTo(HaveOccurred())
Expect(ysqlErr).NotTo(HaveOccurred())
ysqlSession.Wait(2)
Expect(ysqlSession.Err).Should(gbytes.Say("A PITR Config doesn't exist for YSQL namespace yugabyte in cluster stunning-sole. So clone-at-millis parameter must not be specified"))
Expect(ysqlSession.Err).Should(gbytes.Say("No PITR configuration found for YSQL namespace yugabyte in cluster stunning-sole. The 'clone-at-millis' parameter cannot be used unless a valid PITR configuration is set up"))
ysqlSession.Kill()
})

Expand Down