Skip to content

toggleBold when editorHasSelection #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

toggleBold when editorHasSelection #1262

wants to merge 1 commit into from

Conversation

@shanehh
Copy link

@shanehh shanehh commented Apr 13, 2023 •
edited
Loading

There's a conflict between the shortcut key cmd+b for toggleBold and View: Toggle Primary Side Bar Visibility, I found that addingeditorHasSelection can workaround and improve the UX.

@yzhang-gh
Copy link
Owner

yzhang-gh commented Apr 13, 2023

Thanks for your interest.

However, it is by design that you can use toggleBold even if there is no selection (it will select the word under the cursor).

@yzhang-gh yzhang-gh added the Area: Input Related to editor input processing (key presses, key bindings). label Apr 13, 2023
mavaddat
mavaddat approved these changes Sep 28, 2023
View reviewed changes
Copy link

@mavaddat mavaddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mavaddat mavaddat mavaddat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Input Related to editor input processing (key presses, key bindings).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shanehh @yzhang-gh @mavaddat