Open
Conversation
z-x-yang
requested changes
Feb 26, 2026
Owner
z-x-yang
left a comment
There was a problem hiding this comment.
Thanks for the CPU-fallback refactor — good direction. I can't approve this yet because there are still blocking issues:
- CPU path still breaks in
eval.py/train.py
- The CPU branch passes
rank=NoneintoEvaluator/Trainer. - But manager code still assumes GPU-only semantics (
cfg.* + rank,torch.cuda.set_device(...), many.cuda(...)usages). - This will fail before evaluation/training starts on CPU.
- Single-GPU device-id regression
- Single-device launch now calls
main_worker(args.gpu_id, ...)/main_worker(args.start_gpu, ...). - Manager code also adds offsets (
cfg.TEST_GPU_ID + rank,cfg.DIST_START_GPU + rank). - For non-zero GPU ids this can double-offset and select the wrong device.
- CUDA-only timing/memory calls are still unguarded in evaluator
torch.cuda.Event,torch.cuda.synchronize,torch.cuda.max_memory_allocatedstill run in code paths that need CPU compatibility.
Please fix these before merge. Suggested direction:
- Keep
rankas an integer (e.g., 0) on CPU; - Guard all CUDA-only APIs with
torch.cuda.is_available(); - Keep device selection in one place to avoid double offsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.