Conversation
This comment was marked as resolved.
This comment was marked as resolved.
tmontaigu
force-pushed
the
tm/ks32-test-shortint
branch
3 times, most recently
from
5c57731 to
1926f54
Compare
tmontaigu
force-pushed
the
tm/ks32-test-shortint
branch
from
1926f54 to
313f835
Compare
Make KS32 params the default, add them to tests, and add a PARAM_PROD param alias which is still the KS-PBS so that it's still tested. Prod params are tested in a separate workflow to avoid growing the time tests take. BREAKING CHANGE: `PARAM_MESSAGE_2_CARRY_2` now returns `KeySwitch32PBSParameters` instead of `ClassicPBSParameters`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make KS32 params the default, add them to tests,
and add a PARAM_PROD param alias which is still the KS-PBS
so that it's still tested.
Prod params are tested in a separate workflow to avoid growing the
time tests take.
BREAKING CHANGE:
PARAM_MESSAGE_2_CARRY_2now returnsKeySwitch32PBSParametersinstead of
ClassicPBSParameters.