feat(hpu): HPU backend now uses a shared atomic counter#3195
Open
pgardratzama wants to merge 3 commits intomainfrom
Open
feat(hpu): HPU backend now uses a shared atomic counter#3195pgardratzama wants to merge 3 commits intomainfrom
pgardratzama wants to merge 3 commits intomainfrom
Conversation
Contributor
Author
|
verifed stability with loop of x92 hpu test u64 (no error) and ERC20 throughput bench |
Contributor
Author
|
seems to impact reloading of FPGA: because AMI proc file is open, cannot remove ami driver correctly, need a fix |
pgardratzama
force-pushed
the
hw-team/pg/shared_atomic_cnt
branch
from
2842230 to
9f24a9f
Compare
pgardratzama
force-pushed
the
hw-team/pg/shared_atomic_cnt
branch
from
9f24a9f to
f5cb6c1
Compare
Contributor
Author
|
with munmap before unloading of AMI driver, reload of FPGA works well |
…er to get the IOp acknowledge (expects AMI v3.2.0)
pgardratzama
force-pushed
the
hw-team/pg/shared_atomic_cnt
branch
from
1b75c01 to
cc65097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to get IOp ack from AMI driver
requires AMI driver 3.2.0 currently in PR zama-ai/AVED#10
does not seem to have deep impact on bench performance because but still better than while (1) { open - read - close }
tested on simple run of hpu_bench, integer & erc20 throughput tests