chore: fix comment in generate lookup table#3385
Merged
IceTDrinker merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
Member
IceTDrinker
commented
Mar 11, 2026
IceTDrinker
commented
- at some point the code likely took the padding bit into account, the corresponding comment was left unchanged which was an error
- propagate everywhere this comment was copy/pasted
- at some point the code likely took the padding bit into account, the corresponding comment was left unchanged which was an error - propagate everywhere this comment was copy/pasted
IceTDrinker
requested review from
a team,
mayeul-zama and
nsarlin-zama
as code owners
pdroalves
reviewed
Mar 11, 2026
| @@ -63,7 +63,7 @@ uint64_t *generate_identity_lut_pbs(int polynomial_size, int glwe_dimension, | |||
| // Modulus of the msg contained in the msg bits and operations buffer | |||
| uint64_t modulus_sup = message_modulus * carry_modulus; | |||
Contributor
There was a problem hiding this comment.
Do we need to change something here or was only a matter of adjusting the comment?
Member
Author
There was a problem hiding this comment.
in what way ? normally the code is correct otherwise you would have issues, the reason for the modulus_sup is that the LUT represents the whole plaintext space (so msg + carry)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.