feat(gpu): enable multi-bit test to the pattern dp ks ms#3395
Draft
guillermo-oyarzun wants to merge 7 commits intomainfrom
Draft
feat(gpu): enable multi-bit test to the pattern dp ks ms#3395guillermo-oyarzun wants to merge 7 commits intomainfrom
guillermo-oyarzun wants to merge 7 commits intomainfrom
Conversation
96872e5 to
ab4338a
Compare
ab4338a to
745d588
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR to enable multi-bit tests, the tricky part is that our pbs must have an option to receive an input already modulus switched. This affects only to the keybundle, however to keep the changes minimal the input of the keybundle will contain the original input array at the start of the array and the second part of the array contains the modulus switched values.
This order is needed cause the pbs needs to read the input body untouched (other ways to change it would imply also to change the blind rotation).
Check-list: