Open
Conversation
This function is used to clear gpu thread locals. This is mainly useful to counter the 'bug' where a rayon pool does not wait for its threads to exit, which creates sync problems between the cuda driver and the cpu thread thread_local
| let pool = ThreadPoolBuilder::new() | ||
| .num_threads(8 * num_gpus) | ||
| .exit_handler(|_| unset_server_key()) | ||
| .exit_handler(|_| clear_gpu_thread_locals()) |
Member
There was a problem hiding this comment.
is there a way to keep this as default or we will need to remember to add it all the times we use it?
Contributor
Author
There was a problem hiding this comment.
If we only want to have unset_server_key we should remove the extra CudaStreamPool used by decrypt, which I think is ok to remove
otherwise we should keep clear_gpu_thread_locals, its only needed when using a non local rayon pool
guillermo-oyarzun
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is used to clear gpu thread locals.
This is mainly useful to counter the 'bug' where a rayon pool does not wait for its threads to exit, which creates sync problems between the cuda driver and the cpu thread thread_local