-
-
Notifications
You must be signed in to change notification settings - Fork 736
ascanrulesAlpha: Add Suspicious Input Transformation Script #6768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ascanrulesAlpha: Add Suspicious Input Transformation Script #6768
Conversation
57e3ac5
to
04acace
Compare
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
); | ||
const CommonAlertTag = Java.type("org.zaproxy.addon.commonlib.CommonAlertTag"); | ||
const RandomStringUtils = Java.type( | ||
"org.apache.commons.lang3.RandomStringUtils", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comma?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used prettier
to format the script, that added the comma...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, just seemed out of place 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
id: 100044 | ||
name: Suspicious Input Transformation | ||
description: > | ||
The application performed suspicious input transformation that may indicate a security vulnerability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...a suspicious...
or
....transformations...
HttpMessage msg = getHttpMessage(path + "?param=value"); | ||
|
||
// When | ||
rule.init(msg, parent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda nit picky but I think most of the Java rule tests have the init as part of the // Given block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was thinking that too, will tweak
0483978
to
452ff8b
Compare
Signed-off-by: ricekot <[email protected]>
452ff8b
to
efc9845
Compare
No description provided.