Skip to content

Conversation

ricekot
Copy link
Member

@ricekot ricekot commented Sep 19, 2025

No description provided.

@ricekot ricekot force-pushed the ascanrulesAlpha/add-sus-input-transform-rule branch 2 times, most recently from 57e3ac5 to 04acace Compare September 19, 2025 19:03
@psiinon
Copy link
Member

psiinon commented Sep 19, 2025

Logo
Checkmarx One – Scan Summary & Details5ac83b2d-5a5a-4db7-b20f-20b86e9fe8d3

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

);
const CommonAlertTag = Java.type("org.zaproxy.addon.commonlib.CommonAlertTag");
const RandomStringUtils = Java.type(
"org.apache.commons.lang3.RandomStringUtils",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma?

Copy link
Member Author

@ricekot ricekot Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used prettier to format the script, that added the comma...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, just seemed out of place 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

id: 100044
name: Suspicious Input Transformation
description: >
The application performed suspicious input transformation that may indicate a security vulnerability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...a suspicious...
or
....transformations...

HttpMessage msg = getHttpMessage(path + "?param=value");

// When
rule.init(msg, parent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda nit picky but I think most of the Java rule tests have the init as part of the // Given block

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking that too, will tweak

@ricekot ricekot force-pushed the ascanrulesAlpha/add-sus-input-transform-rule branch 3 times, most recently from 0483978 to 452ff8b Compare September 20, 2025 03:16
@ricekot ricekot force-pushed the ascanrulesAlpha/add-sus-input-transform-rule branch from 452ff8b to efc9845 Compare September 20, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants