-
-
Notifications
You must be signed in to change notification settings - Fork 353
Apply ruff preview rule #3131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Apply ruff preview rule #3131
Conversation
17048f6
to
bc765d8
Compare
I'm 👍 for spelling fixes, and 👎 for refactoring without a linter doing it automatically for us (because it just creates PR review noise for not much technical debt reduction). Could you open a PR to repalce this that just includes the spelling fixes? |
I think Sourcery applies linter rules, but rules that might not be part of ruff (yet). More importantly, I think Sourcery is a good addition - AI assistance for PR review. But I understand you don't agree with it. Some of the Sourcery suggestions - n_ellipsis = sum(1 for i in selection if i is Ellipsis)
+ n_ellipsis = selection.count(Ellipsis) How about keeping the couple changes that really make sense? |
bec6be5
to
7270dd1
Compare
f55e79a
to
5a1df20
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 78 78
Lines 9419 9419
=======================================
Hits 8905 8905
Misses 514 514
🚀 New features to boost your workflow:
|
58a885b
to
ae772b5
Compare
ae772b5
to
03d87ce
Compare
03d87ce
to
679e33e
Compare
FURB140 Use `itertools.starmap` instead of the generator
679e33e
to
6c9c486
Compare
6c9c486
to
3161442
Compare
Also a couple Pylint rules that may not yet be implemented in ruff.
TODO:
docs/user-guide/*.rst
changes/