Skip to content

fix: clippy warnings for publish readiness#285

Merged
jkmaina merged 2 commits intomainfrom
feat/gemini3-function-calling
Apr 15, 2026
Merged

fix: clippy warnings for publish readiness#285
jkmaina merged 2 commits intomainfrom
feat/gemini3-function-calling

Conversation

@jkmaina
Copy link
Copy Markdown
Collaborator

@jkmaina jkmaina commented Apr 15, 2026

Resolve all clippy warnings across the workspace for publish readiness.

Fixes:

  • adk-audio: remove needless borrow in GeminiStt
  • adk-gemini: use zip iterators in property tests, array literals in unit tests
  • adk-model: use zip iterators in property tests
  • adk-agent: remove needless borrow in shared_state integration test

Quality gates (all pass):

  • cargo fmt --all -- --check: clean
  • cargo clippy --workspace --all-targets -- -D warnings: zero warnings
  • cargo nextest run --workspace: 1938 passed, 0 failed, 77 skipped

James Karanja added 2 commits April 15, 2026 20:33
- adk-audio/src/providers/stt/gemini.rs: remove needless borrow
- adk-gemini/tests/multimodal_fn_response_tests.rs: use zip iterators
- adk-model/tests/multimodal_conversion_tests.rs: use zip iterators
- adk-gemini/src/models.rs: use array literals instead of vec! in tests
- adk-agent/tests/shared_state_integration_tests.rs: remove needless borrow

All quality gates pass:
- cargo fmt --all -- --check: clean
- cargo clippy --workspace --all-targets -- -D warnings: zero warnings
- cargo nextest run --workspace: 1938 passed, 0 failed
GitHub doesn't render audio for plain WAV links. Use an <audio> tag
pointing to the raw file URL so the podcast plays inline on the README.
@jkmaina jkmaina merged commit 80d8a83 into main Apr 15, 2026
10 checks passed
@jkmaina jkmaina deleted the feat/gemini3-function-calling branch April 15, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant