Improve TS and JS symbol outline #39797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and method bodies
fix: failing tests for ts outline
Took it from how JSON's outline is constructed
add: missing comments
change: simpler comments
|
We require contributors to sign our Contributor License Agreement, and we don't have @ogdakke on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
maxdeviant
changed the title
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
1 similar comment
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more granular symbols for ts and js in outline panel. This is a bit closer to what vscode offers.
Screenshots of current vs new
New:
Current:
Current vscode (cursor):
I have never touched scheme before, and pair-programmed this with ai, so please let me know if there's any glaring issues with the implementation. I just miss the outline panel in vscode very much, and would love to see this land.
Happy to help with tsx/jsx as well if this is the direction you guys were thinking of taking the outline impl.
Doesn't fully close #20964 as there is no support for chained class method callbacks or
Class.prototype.method = ...as mentioned in #21243, but this is a step forward.Release Notes: