Persist agent permission mode selection across sessions #39816
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zed-industries#39392 When a user selects a permission mode (e.g., 'Bypass Permissions') in the Claude Code agent, the mode now automatically persists as the default. Previously, the mode would only change for the current session and revert to the previous default when creating a new thread or session. Changes: - Mode selection now always saves as default (unless modifier key is held) - Holding the secondary modifier key (Ctrl/Cmd) allows toggling/unsetting the default mode - Updated tooltip text to reflect the new behavior This ensures that user's permission mode preferences persist across sessions as expected.
|
We require contributors to sign our Contributor License Agreement, and we don't have @jefflouisma on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
SomeoneToIgnore
added
the
ai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39392
Summary
Fixes an issue where the "Bypass Permissions" setting (and other permission modes) in Claude Code agent would automatically revert when creating new threads or sessions.
Problem
When users selected a permission mode like "Bypass Permissions" from the dropdown:
Solution
Modified the mode selector behavior in
crates/agent_ui/src/acp/mode_selector.rs:Changes
Testing
./script/clippy -p agent_uiRelease Notes: