-
Notifications
You must be signed in to change notification settings - Fork 5.5k
vim: Add gt and gT bindings for Markdown preview mode #39854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
vim: Add gt and gT bindings for Markdown preview mode #39854
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have @Pranav2612000 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@Pranav2612000 thanks for this! It turns out it didn't work quite right because the preview component is not an editor, so the action didn't trigger. I've fixed that and also made the binding work on all non-Editors (like screen share, and welcome screen etc.) |
Great! Thank you for the fix @ConradIrwin
Oh! Weird! Apologies for sending in the wrong fix. I tested out with a local build on a mac and it seemed to work. Doesn't the Markdown preview have the "MarkdownPreview" context ( atleast thats what logs told me ), and so the bindings should apply to it? Anyways, the fix to make it work on all non-editors is amazing ❤️ ! Thank you very much 🙇🏾 |
Ahh, I see some issues on this branch. Seem to be low priority. I'll love to work on them. Let me know what you think.
|
What does this PR do?
gt
for navigating to the next tab andgT
for navigating to the previous tab in markdown viewer modeWhy do we need this change?
gt
andgT
) do not work for navigating between tabs. These bindings work everywhere else, which provides a non-consistent experience for the user.How do we do this change?