git_ui: Fix open diff for untracked files when sorting by path enabled #39862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the "Open Diff" action for untracked files with the `sort_by_path` setting is enabled.
cla-bot
bot
added
the
cla-signed
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
Open Diffaction for untracked files when thesort_by_pathsetting is enabled. TheProjectDiffwasn't correctly moving the multibuffer's cursor to the untracked file because, when that setting is enabled, it's namespace is changed to the tracked namespace, and that wasn't accounted for inmove_to_entry.Closes #39529
Release Notes:
sort_by_pathis enabled