-
-
Notifications
You must be signed in to change notification settings - Fork 0
✨ Add boxed module #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41fb9d6
to
cc425ba
Compare
Keeping this in draft until heapless 0.9 is released (hopefully with my needed fixes) and we can then switch to using that. I'll also tackle the MSRV issue (probably just need bumping again). |
This enables dependency on the `portable-atomic` crate and enables the `portable-atomic` feature of `heapless`.
@mkj If you adding the 👀 reaction to the PR means that you might be interested in this feature, I could use a second pair of eyes on this so if you could review it, that would be very helpful. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping - not sure if I'll be using boxed, though other bits of mayheap look useful for me in a couple of crates.
This PR looks good. A couple of minor thoughts.
That was an extremely helpful review. Thanks so much! If you could just have one last look before I merge, that would be great. |
Looks good. I think the
|
This is an abstraction over `heapless::pool::boxed` and `alloc::boxed`.
Oh right, good catch! I had forgotten that
Great idea. Done! |
@mkj Many thanks for your help! 🙏👍 |
This is an abstraction over
heapless::pool::boxed
andalloc::boxed
.