Skip to content

Conversation

GoodbyeNJN
Copy link

@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 18:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new SmartCopy action that provides seamless copy functionality with intelligent key handling. The action copies selected text when a selection exists, otherwise passes the key through to the terminal as a regular interrupt signal.

  • Adds SmartCopy action variant to the Action enum and corresponding error context
  • Implements routing logic that checks for text selection before deciding whether to copy or pass through the key
  • Updates KDL parsing and protocol conversion to support the new action type

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
zellij-utils/src/input/actions.rs Adds SmartCopy variant to the Action enum
zellij-utils/src/errors.rs Adds SmartCopy to the ScreenContext enum for error handling
zellij-utils/src/kdl/mod.rs Adds KDL parsing support for "SmartCopy" action
zellij-utils/src/plugin_api/action.rs Adds SmartCopy to unsupported protobuf actions list
zellij-server/src/route.rs Implements routing logic and adds key context parameters
zellij-server/src/screen.rs Adds SmartCopy screen instruction and processing logic
zellij-server/src/tab/mod.rs Adds selection checking and reset methods to Tab
zellij-server/src/panes/ Implements has_selection method for different pane types
example/ Updates example configurations with commented SmartCopy keybinding examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant